Skip to content

feat: wot core service#642

Open
saniddhyaDubey wants to merge 5 commits into
cameri:mainfrom
saniddhyaDubey:feat/wot#2-service
Open

feat: wot core service#642
saniddhyaDubey wants to merge 5 commits into
cameri:mainfrom
saniddhyaDubey:feat/wot#2-service

Conversation

@saniddhyaDubey

Copy link
Copy Markdown
Collaborator

Description

Introduces WotService - the core Web of Trust graph logic. Builds a 2-hop trust graph rooted at the relay owner's pubkey by fetching kind-3 follow lists from configured seed relays.
Also patches the wot: config block (#623) with the missing seedRelays field, and updates the settings unit tests accordingly.

Related Issue

Closes (#626).

How Has This Been Tested?

14 new unit tests in test/unit/services/wot-service.spec.ts cover:

  • Initial state (not ready, no pubkeys trusted)
  • seedPubkey always trusted regardless of follower count
  • minimumFollowers threshold : pubkeys above pass, pubkeys below are rejected
  • Unknown pubkeys return false
  • In-flight build guard — concurrent buildGraph() calls are no-ops
  • building flag cleared correctly even when the build throws
  • Tag parsing — non-p tags and pubkeys shorter than 64 chars ignored
  • reset() clears all state and allows a fresh build

Screenshots (if appropriate):

Screenshot 2026-06-07 at 1 38 43 PM Passing all unit test mentioned above

Types of changes

  • [ X ] New feature (non-breaking change which adds functionality)

Checklist:

  • [ X ] My code follows the code style of this project.
  • [ X ] I have added tests to cover my code changes.
  • [ X ] I added a changeset, or this is docs-only and I added an empty changeset.
  • [ X ] All new and existing tests passed.

@changeset-bot

changeset-bot Bot commented Jun 7, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a36249d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls

coveralls commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 66.588% (-0.2%) from 66.747% — saniddhyaDubey:feat/wot#2-service into cameri:main

Comment thread src/services/wot-service.ts Outdated
Comment thread src/services/wot-service.ts Outdated
Comment thread src/services/wot-service.ts Outdated
Comment thread src/services/wot-service.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a new WotService implementing the core Web of Trust (WoT) graph-building logic, along with settings/type updates and unit tests to support and validate the new behavior.

Changes:

  • Adds WotService to build a 2-hop trust graph by fetching kind-3 follow lists from configured seed relays.
  • Extends WoT settings to include seedRelays, updates default settings, and adjusts settings unit tests.
  • Adds a comprehensive unit test suite for WotService.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/services/wot-service.ts Adds the WoT graph building logic with relay fetching, batching, and trust-map swapping.
src/@types/settings.ts Extends WoTSettings with seedRelays.
src/@types/services.ts Introduces the IWotService interface.
resources/default-settings.yaml Adds default wot.seedRelays values.
test/unit/services/wot-service.spec.ts Adds unit tests covering WoT service behavior and edge cases.
test/unit/utils/settings.spec.ts Updates settings tests to assert seedRelays defaulting and override behavior.
.knip.json Ignores the new service file for unused-code checks.
.changeset/solid-boats-try.md Adds a changeset entry for the new feature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

minimumFollowers: 1
# Hours between full trust graph rebuilds.
refreshIntervalHours: 24
# Relay URLs to fetch follow lists from when building the trust graph.
Comment thread src/@types/settings.ts
Comment on lines +286 to +290
/**
* Relay URLs to fetch follow lists from when building the trust graph.
* Falls back to the relay's own URL if empty.
*/
seedRelays: string[]
Comment thread test/unit/services/wot-service.spec.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants